Fix nasa#169, Trigger workflow on pull requests

Set fail-fast to false for all workflows
Clean up comments

.github/workflows/build-cfs-deprecated.yml

@@ -1,11 +1,10 @@
 name: "Deprecated Build, Test, and Run"
 
 # Run this workflow every time a new commit pushed to your repository
-on: push
+on: [push, pull_request]
 
 env:
   SIMULATION: native
-  ENABLE_UNIT_TESTS: true
   OMIT_DEPRECATED: false
 
 jobs:
@@ -18,6 +17,7 @@ jobs:
     runs-on: ubuntu-18.04
 
     strategy:
+      fail-fast: false
       matrix:
         buildtype: [debug, release]
 
@@ -51,12 +51,15 @@ jobs:
     runs-on: ubuntu-18.04
 
     strategy:
+      fail-fast: false
       matrix:
         buildtype: [debug, release]
 
     # Set the type of machine to run on
     env:
       BUILDTYPE: ${{ matrix.buildtype }}
+      ENABLE_UNIT_TESTS: true
+
 
     steps:
       - name: Install Dependencies
@@ -90,6 +93,7 @@ jobs:
     runs-on: ubuntu-18.04
 
     strategy:
+      fail-fast: false
       matrix:
         buildtype: [debug, release]
 

.github/workflows/build-cfs.yml

@@ -1,7 +1,7 @@
 name: Build, Test, and Run [OMIT_DEPRECATED=true]
 
-# Run this workflow every time a new commit pushed to your repository
-on: push
+# Run this workflow every time a new commit pushed to your repository or for new pull requests
+on: [push, pull_request]
 
 env:
   SIMULATION: native
@@ -14,6 +14,7 @@ jobs:
     runs-on: ubuntu-18.04
 
     strategy:
+      fail-fast: false
       matrix:
         buildtype: [debug, release]
 
@@ -22,7 +23,7 @@ jobs:
       BUILDTYPE: ${{ matrix.buildtype }}
 
     steps:
-      # Checks out a copy of your repository on the ubuntu-latest machine
+      # Check out the cfs bundle
       - name: Checkout code
         uses: actions/checkout@v2
         with:
@@ -48,6 +49,7 @@ jobs:
     needs: build-cfs
 
     strategy:
+      fail-fast: false
       matrix:
         buildtype: [debug, release]
 
@@ -89,6 +91,7 @@ jobs:
     runs-on: ubuntu-18.04
 
     strategy:
+      fail-fast: false
       matrix:
         buildtype: [debug, release]
 

.github/workflows/build-documentation.yml

@@ -1,30 +1,28 @@
 name: Documentation and Guides
 
-# Run this workflow every time a new commit pushed to your repository
-on: push
+# Run this workflow every time a new commit pushed to your repository or for new pull requests
+on: [push, pull_request]
 
 env:
   SIMULATION: native
 
 jobs:
 
   build-docs:
-    # Name the Job
     name: cFE Documentation
-    # Set the type of machine to run on
     runs-on: ubuntu-18.04
 
     steps:
       - name: Install Dependencies
         run: sudo apt-get install doxygen graphviz -y
 
-      # Checks out a copy of your repository on the ubuntu-latest machine
+        # Check out the cfs bundle
       - name: Checkout code
         uses: actions/checkout@v2
         with:
           submodules: true
 
-      # Setup the build system
+      # Prepare build "recipes"
       - name: Copy Files
         run: |
           cp ./cfe/cmake/Makefile.sample Makefile
@@ -38,7 +36,8 @@ jobs:
         run: |
           make doc > make_doc_stdout.txt 2> make_doc_stderr.txt
 
-      - name: Archive Users Guide Build Logs
+      # Upload documentation logs as artifacts
+      - name: Archive Documentation Build Logs
         uses: actions/upload-artifact@v2
         with:
           name: cFS Docs Artifacts

.github/workflows/static-analysis.yml

@@ -1,25 +1,16 @@
 name: Static Analysis
 
 # Run this workflow every time a new commit pushed to your repository
-on: push
-
-env:
-  SIMULATION: native
+on: [push, pull_request]
 
 jobs:
 
-  # Set the job key. The key is displayed as the job name
-  # when a job name is not provided
-
   static-analysis:
     name: Run cppcheck
     runs-on: ubuntu-18.04
 
     strategy:
-<<<<<<< HEAD
-=======
       fail-fast: false
->>>>>>> aeda0dd... remove 'quiet' from cfe, osal, and psp checks
       matrix:
         cppcheck: [bundle, cfe, osal, psp]