Fixes matching of similar dynamic parameters #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Bug
If I have below dynamic routes:
/blog/[slug]
/user/[slug]
When I change the language selector from above both routes, I'll always return the
/blog/[slug]
.Description
Original method to find the dynemic route is not working for finding two (or more) dynamic routes, because it just compare the route params keys (like
slug
) and return the first one:i18n/package/assets/stubs/virtual.mjs
Lines 240 to 246 in 46686bd
If I have below dynamic routes:
/blog/[slug]
/user/[slug]
It will always return the
/blog/[slug]
because it's the first one.So I've changed to the RegExp to match the dynamic routes.
Testing
I've add the
/user/[slug]
route into the playground.You can follow the steps below to test:
fr
and you'll see the/user/[slug]
route is returned/blog/[slug]
route is returned