Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider ingest of astro sdk docs #165

Closed
11 tasks
mpgreg opened this issue Nov 21, 2023 · 2 comments · Fixed by #199
Closed
11 tasks

Consider ingest of astro sdk docs #165

mpgreg opened this issue Nov 21, 2023 · 2 comments · Fixed by #199
Assignees

Comments

@mpgreg
Copy link
Contributor

mpgreg commented Nov 21, 2023

Please describe the feature you'd like to see
Astro sdk is referenced in docs.astronomer.io (which we ingest) but not always accurate. Should ingest astro sdk specific docs.

Describe the solution you'd like
Can probably use consolidated HTML ingest with https://astro-sdk-python.readthedocs.io/en/stable/

Are there any alternatives to this feature?

Additional context

Acceptance Criteria

  • All checks and tests in the CI should pass
  • Unit tests
  • Integration tests (if the feature relates to a new database or external service)
  • Example DAG
  • Docstrings in reStructuredText for each of methods, classes, functions and module-level attributes (including Example DAG on how it should be used)
  • Exception handling in case of errors
  • Logging (are we exposing useful information to the user? e.g. source and destination)
  • Improve the documentation (README, Sphinx, and any other relevant)
  • How to use Guide for the feature (example)

Note:

  • After the implementation is complete, the data should be ingested to the dev database and the dev slackbot should be deployed.
  • This change should be tested by @vatsrahul1001 and after his take on quality of response, this should be merged
@sunank200
Copy link
Collaborator

Note:

  • After the implementation is complete, the data should be ingested to the dev database and the dev slackbot should be deployed.
  • This change should be tested by @vatsrahul1001 and after his take on quality of response, this should be merged

@phanikumv
Copy link
Collaborator

@pankajastro to link the PRs created for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants