feat(airflow): add astro-cli ingestion #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sunank200
reviewed
Dec 4, 2023
There was a problem hiding this comment.
I think you need to add this change to bulk ingestion DAG as well for loading it the first time: https://github.com/astronomer/ask-astro/blob/main/airflow/dags/ingestion/ask-astro-load.py
Deploying with
|
| Latest commit: |
e8a77cd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2813111d.ask-astro.pages.dev |
| Branch Preview URL: | https://ingest-astro-cli-docs.ask-astro.pages.dev |
Lee-W
force-pushed
the
ingest-astro-cli-docs
branch
from
ce05b5e to
236162a
Compare
sunank200
approved these changes
Dec 11, 2023
|
|
||
|
|
||
| def extract_astro_cli_docs() -> list[pd.DataFrame]: | ||
| astronomer_base_url = "https://docs.astronomer.io" |
There was a problem hiding this comment.
Can you add the doc strings please?
Lee-W
force-pushed
the
ingest-astro-cli-docs
branch
from
236162a to
e8a77cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #190