-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Ingestion Improvement/Cleanup/Bug Fix - Part 2 #307
Conversation
Deploying with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left 1 nitpick. Rest looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But this might require a fresh ingestion for testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidgxue requesting you to do the fresh ingestion to the new Database and test the changes before merging.
Updated the PR description with test results!! |
Code ready for review, evaluations/testing is still in progress
Description
Technical Changes
split.py
file tochunking_utils.py
(multiple files changed due to import naming)stable
version of the docs.Evaluations
data_ingest_comparison_part_2.csv
data_ingest_results_part_2.csv
Related Issues
closes #221
closes #258
closes #295 (Reranker has been addressed in GCP environment variables, embedding model change completed in a different PR)
closes #285 (This PR prevents empty docs from being ingested)