Modify the API's Server to Allow CORS #311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sunank200
commented
Mar 5, 2024
sunank200
commented
- Modify the API's Server to Allow CORS
sunank200
requested review from
Lee-W,
pankajastro,
davidgxue and
jlaneve
as code owners
Deploying with
|
| Latest commit: |
00cc782
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://50bb7649.ask-astro.pages.dev |
| Branch Preview URL: | https://enable-cros.ask-astro.pages.dev |
pankajastro
approved these changes
Mar 5, 2024
|
What is adding allowing CORS for exactly? Can you add more details? I think svelte and slack api work just fine right now without it? |
davidgxue
reviewed
Mar 6, 2024
| @@ -18,6 +19,8 @@ | |||
|
|
|||
| api = Sanic(name="ask_astro") | |||
|
|
|||
| CORS(api, resources={r"/api/*": {"origins": "*"}}) | |||
There was a problem hiding this comment.
In general it is not a good practice to allow * wildcard origin. Specify a domain name or something here.
But why are we adding this? The current service works just fine without it?
There was a problem hiding this comment.
We are not adding it @davidgxue it was just for the hackathon as we were using dev API of ask-astro
There was a problem hiding this comment.
Okay sounds good. As long as you don't merge this in then that's cool!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.