-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup and run end to end #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
Lee-W
force-pushed
the
setup-and-run-end-to-end
branch
from
October 18, 2023 04:12
64939af
to
04a908a
Compare
4 tasks
sunank200
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Over all looks good to me. Following needs to be added.
- Installation of poetry and missing requirements if any.
Lee-W
force-pushed
the
setup-and-run-end-to-end
branch
from
October 19, 2023 08:41
5582ca3
to
5105d9c
Compare
This was referenced Oct 19, 2023
Run the ask astro chat end to end on a private slack account after migration to new GCP account.
#38
Closed
Lee-W
force-pushed
the
setup-and-run-end-to-end
branch
from
October 20, 2023 04:35
1ed63cb
to
407af09
Compare
pankajastro
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is documenting how to set the slack bot for ask-astro https://github.com/astronomer/ask-astro/blob/setup-and-run-end-to-end/docs/api/setup_slack_bot.md
Other are minor improvement and scripts to run ask-astro API locally
Closes: #32 #38