Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global .env file + handling #6

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

global .env file + handling #6

wants to merge 3 commits into from

Conversation

carterjfulcher
Copy link
Contributor

Loads a dotenv from the project root and provides an example of how to use it.

Great Airflow Summit talk by the way! @jlaneve

@jlaneve
Copy link
Collaborator

jlaneve commented Sep 23, 2023

thanks for opening the PR! going to hold off on merging while we evaluate the architecture and local developer experience this week

sunank200
sunank200 requested changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@sunank200 sunank200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a great idea to have a .env file locally as developers can mistakenly have their .env file pushed to the main. @pankajastro @Lee-W WDYT?

@carterjfulcher
Copy link
Contributor Author

It's not a great idea to have a .env file locally as developers can mistakenly have their .env file pushed to the main. @pankajastro @Lee-W WDYT?

That's what .gitignore is for :)

@Lee-W
Copy link
Collaborator

Lee-W commented Nov 16, 2023

It's not a great idea to have a .env file locally as developers can mistakenly have their .env file pushed to the main. @pankajastro @Lee-W WDYT?

That's what .gitignore is for :)

agree

It's not a great idea to have a .env file locally as developers can mistakenly have their .env file pushed to the main. @pankajastro @Lee-W WDYT?

I'm good with it

Lee-W
Lee-W reviewed Nov 16, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
.env.example Show resolved Hide resolved
api/ask_astro/__init__.py Outdated Show resolved Hide resolved
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 23, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c43ffc1
Status: ✅  Deploy successful!
Preview URL: https://c95e3718.ask-astro.pages.dev
Branch Preview URL: https://main.ask-astro.pages.dev

View logs

carterjfulcher and others added 2 commits February 22, 2024 20:52
@carterjfulcher @Lee-W
Update api/ask_astro/__init__.py
fbbce96 
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
@carterjfulcher
Merge branch 'main' into env
65b54cc
@carterjfulcher carterjfulcher requested a review from Lee-W February 23, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunank200 sunank200 sunank200 requested changes

@pankajastro pankajastro Awaiting requested review from pankajastro pankajastro is a code owner

@davidgxue davidgxue Awaiting requested review from davidgxue

@Lee-W Lee-W Awaiting requested review from Lee-W Lee-W is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carterjfulcher @jlaneve @Lee-W @sunank200