Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly tell users in error logs when keys are expired #1469

Closed
2 of 4 tasks
odaneau-astro opened this issue Dec 15, 2023 · 2 comments · Fixed by #1634
Closed
2 of 4 tasks

Explicitly tell users in error logs when keys are expired #1469

odaneau-astro opened this issue Dec 15, 2023 · 2 comments · Fixed by #1634

Comments

@odaneau-astro
Copy link

✍️ Is your feature request related to a problem? Please describe.
A user from Pepperstone complained that astro deploy stopped working for her recently.
The error message did not explicitly mention that her API Token was expired.

Im trying to get a first prod grade dag rolled up to astro, figuring things out,
I am facing an issue while pushing it and the log as follows,
Using an Astro API Token
Error: failed to find a valid workspace: failed to get current Workspace: current workspace context not set, you can switch to a workspace with
stro workspace switch WORKSPACEID
Usage:
astro deploy DEPLOYMENT-ID [flags]
Any clue what the error here could be: Do i need to additionally specify the workspace, wouldnt it automatically be redirected to the workspace based on the deployment ID or am i wrong here? Thanks.
astro deploy --dags clni2cukx427177zewdxssirwmb

Spent hours but figured out the issue, the api key which was configured previously has been expired 8 days ago 🤦
Error logging could have been better.

🧩 Describe the solution you'd like

Add logs saying the key is expired when reporting errors

🤔 Describe alternatives you've considered

None

Is your feature request specific to a particular Astronomer Platform?

  • Astro
  • Software
  • None/Unknown

💡 Additional context

image

@sunkickr
Copy link
Contributor

Also create an error for when the token does not exist

@vandyliu
Copy link
Contributor

https://astronomer.slack.com/archives/CL44PA4DB/p1694772492568969
for some more context as well

@ichung08 ichung08 linked a pull request Apr 25, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants