Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error msg if API Token is expired #1634

Merged

Conversation

ichung08
Copy link
Contributor

@ichung08 ichung08 commented Apr 25, 2024

Description

Describe the purpose of this pull request.

We want to explicitly log to users when an API token is expired.

🎟 Issue(s)

Related #1469

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

  • Added and updated unit tests
  • Tested in CLI

📸 Screenshots

Screenshot 2024-04-29 at 6 43 53 PM

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@ichung08 ichung08 self-assigned this Apr 25, 2024
@ichung08 ichung08 linked an issue Apr 25, 2024 that may be closed by this pull request
4 tasks
cmd/cloud/setup.go Outdated Show resolved Hide resolved
@ichung08 ichung08 changed the title Add error msg if API key is expired Add error msg if API Token is expired Apr 27, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.75%. Comparing base (25d67f4) to head (8d5e293).

❗ Current head 8d5e293 differs from pull request most recent head ecba307. Consider uploading reports for the commit ecba307 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1634   +/-   ##
=======================================
  Coverage   86.74%   86.75%           
=======================================
  Files         114      114           
  Lines       16686    16689    +3     
=======================================
+ Hits        14475    14478    +3     
  Misses       1321     1321           
  Partials      890      890           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ichung08 ichung08 marked this pull request as ready for review April 30, 2024 00:20
…expired' of github.com:astronomer/astro-cli into 1469-explicitly-tell-users-in-error-logs-when-keys-are-expired
@ichung08 ichung08 requested review from jwitz and lzdanski as code owners April 30, 2024 02:04
@ichung08 ichung08 merged commit c7462ca into main Apr 30, 2024
1 of 3 checks passed
@ichung08 ichung08 deleted the 1469-explicitly-tell-users-in-error-logs-when-keys-are-expired branch April 30, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly tell users in error logs when keys are expired
2 participants