-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error msg if API Token is expired #1634
Merged
ichung08
merged 9 commits into
main
from
1469-explicitly-tell-users-in-error-logs-when-keys-are-expired
Apr 30, 2024
Merged
Add error msg if API Token is expired #1634
ichung08
merged 9 commits into
main
from
1469-explicitly-tell-users-in-error-logs-when-keys-are-expired
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ichung08
commented
Apr 26, 2024
ichung08
changed the title
Add error msg if API key is expired
Add error msg if API Token is expired
Apr 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1634 +/- ##
=======================================
Coverage 86.74% 86.75%
=======================================
Files 114 114
Lines 16686 16689 +3
=======================================
+ Hits 14475 14478 +3
Misses 1321 1321
Partials 890 890 ☔ View full report in Codecov by Sentry. |
ichung08
requested review from
neel-astro,
sunkickr and
vandyliu
as code owners
April 30, 2024 00:20
…n-keys-are-expired
kushalmalani
approved these changes
Apr 30, 2024
…expired' of github.com:astronomer/astro-cli into 1469-explicitly-tell-users-in-error-logs-when-keys-are-expired
ichung08
deleted the
1469-explicitly-tell-users-in-error-logs-when-keys-are-expired
branch
April 30, 2024 02:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to explicitly log to users when an API token is expired.
🎟 Issue(s)
Related #1469
🧪 Functional Testing
📸 Screenshots
📋 Checklist
make test
before taking out of draftmake lint
before taking out of draft