Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component Flags to astro deployment logs #1633

Merged
merged 5 commits into from
Apr 26, 2024

Conversation

ichung08
Copy link
Contributor

@ichung08 ichung08 commented Apr 24, 2024

Description

Describe the purpose of this pull request.

Users need to see logs for a specific component (webserver, scheduler, triggerer, worker) of a Deployment. This change will allow users to set specific flags (--webserver) to parse a specific component's flags.

🎟 Issue(s)

Related #1590

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

  • Updated unit tests and added new units
  • CLI Testing:
    • no flags set:
Screenshot 2024-04-24 at 2 17 41 PM
  • all flags set:
Screenshot 2024-04-24 at 1 38 21 PM
  • webserver only:
Screenshot 2024-04-24 at 2 11 46 PM
  • scheduler only:
Screenshot 2024-04-24 at 2 12 01 PM
  • triggerer only:
Screenshot 2024-04-24 at 2 12 12 PM
  • worker only:
Screenshot 2024-04-24 at 2 12 22 PM

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@ichung08 ichung08 self-assigned this Apr 24, 2024
@ichung08 ichung08 linked an issue Apr 24, 2024 that may be closed by this pull request
4 tasks
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.74%. Comparing base (1a67fff) to head (d15ea33).

Files Patch % Lines
cloud/deployment/deployment.go 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1633      +/-   ##
==========================================
- Coverage   86.75%   86.74%   -0.01%     
==========================================
  Files         114      114              
  Lines       16661    16671      +10     
==========================================
+ Hits        14454    14462       +8     
- Misses       1318     1319       +1     
- Partials      889      890       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ichung08 ichung08 marked this pull request as ready for review April 24, 2024 21:23
…ithub.com:astronomer/astro-cli into 1590-add-component-flags-to-astro-deployment-logs
@ichung08 ichung08 requested a review from kushalmalani April 25, 2024 18:30
@ichung08 ichung08 merged commit 067e43c into main Apr 26, 2024
4 of 5 checks passed
@ichung08 ichung08 deleted the 1590-add-component-flags-to-astro-deployment-logs branch April 26, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add component Flags to astro deployment logs
2 participants