-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add component Flags to astro deployment logs #1633
Merged
ichung08
merged 5 commits into
main
from
1590-add-component-flags-to-astro-deployment-logs
Apr 26, 2024
Merged
Add component Flags to astro deployment logs #1633
ichung08
merged 5 commits into
main
from
1590-add-component-flags-to-astro-deployment-logs
Apr 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1633 +/- ##
==========================================
- Coverage 86.75% 86.74% -0.01%
==========================================
Files 114 114
Lines 16661 16671 +10
==========================================
+ Hits 14454 14462 +8
- Misses 1318 1319 +1
- Partials 889 890 +1 ☔ View full report in Codecov by Sentry. |
ichung08
requested review from
neel-astro,
kushalmalani,
sunkickr and
vandyliu
as code owners
April 24, 2024 21:23
…ithub.com:astronomer/astro-cli into 1590-add-component-flags-to-astro-deployment-logs
kushalmalani
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users need to see logs for a specific component (
webserver
,scheduler
,triggerer
,worker
) of a Deployment. This change will allow users to set specific flags (--webserver
) to parse a specific component's flags.🎟 Issue(s)
Related #1590
🧪 Functional Testing
📸 Screenshots
📋 Checklist
make test
before taking out of draftmake lint
before taking out of draft