Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename docs url across cli #1657

Merged
merged 1 commit into from
May 29, 2024
Merged

rename docs url across cli #1657

merged 1 commit into from
May 29, 2024

Conversation

kushalmalani
Copy link
Contributor

@kushalmalani kushalmalani commented May 29, 2024

Description

Describe the purpose of this pull request.

rename docs url across cli

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.73%. Comparing base (d858097) to head (a44c558).

Files Patch % Lines
version/version.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1657      +/-   ##
==========================================
+ Coverage   86.72%   86.73%   +0.01%     
==========================================
  Files         114      114              
  Lines       16707    16707              
==========================================
+ Hits        14489    14491       +2     
+ Misses       1329     1328       -1     
+ Partials      889      888       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lzdanski lzdanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kushalmalani kushalmalani merged commit c11669d into main May 29, 2024
3 of 5 checks passed
@kushalmalani kushalmalani deleted the rename-docs-url branch May 29, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants