Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inspecting deployment is_development_mode #1675

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

feluelle
Copy link
Member

Description

Update the deployment map to return the is_development_mode value instead of the pointer (address).

🎟 Issue(s)

❯ astro deployment inspect clyoma4kq000l01nt2gohsr93 --clean-output --key configuration.is_development_mode
0x1400055b23e

πŸ§ͺ Functional Testing

❯ astro deployment inspect clyoma4kq000l01nt2gohsr93 --clean-output --key configuration.is_development_mode
false

πŸ“‹ Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 86.31%. Comparing base (a8e81d7) to head (abc2a69).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1675   +/-   ##
=======================================
  Coverage   86.31%   86.31%           
=======================================
  Files         116      116           
  Lines       17052    17052           
=======================================
  Hits        14719    14719           
  Misses       1403     1403           
  Partials      930      930           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@sunkickr
Copy link
Contributor

sunkickr commented Jul 16, 2024

@kushalmalani I'm afraid we will need a release for this bug. Maybe we can create a release 1.27.2 with just this change since 1.28 is gonna be dbt on astro

@sunkickr sunkickr merged commit 4435467 into main Jul 17, 2024
4 of 5 checks passed
@sunkickr sunkickr deleted the fix/deployment-inspect-is-development-mode branch July 17, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants