Block dbt deploys from within Astro project #1676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremybeard
requested review from
neel-astro,
kushalmalani,
sunkickr and
vandyliu
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1676 +/- ##
==========================================
- Coverage 86.31% 86.27% -0.05%
==========================================
Files 116 117 +1
Lines 17052 17085 +33
==========================================
+ Hits 14719 14740 +21
- Misses 1403 1409 +6
- Partials 930 936 +6 ☔ View full report in Codecov by Sentry. |
config/config.go
Outdated
| @@ -230,6 +231,26 @@ func IsProjectDir(path string) (bool, error) { | |||
| return fileutil.Exists(configFile, nil) | |||
| } | |||
|
|
|||
| // IsWithinProjectDir returns true if the path is at or within an Astro project directory | |||
| func IsWithinProjectDir(path string) (bool, error) { | |||
| dbtProjectPathAbs, err := filepath.Abs(filepath.Clean(path)) | |||
There was a problem hiding this comment.
If this function not just for DBT, can we make the variable names generic?
There was a problem hiding this comment.
Yes, good call.
kushalmalani
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change blocks the
astro dbt deploycommand from deploying a dbt project that is within an Astro project. This use case is not supported because it can create unexpected behavior when the full Astro project is then deployed withastro deploy.🧪 Functional Testing
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft