Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use commit message for bundle deploy description #1677

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

jeremybeard
Copy link
Contributor

Description

This change uses the local Git checkout commit message as the default description for bundle deploys, such as for astro dbt deploy. If there is no found local Git checkout the default description is left blank.

🧪 Functional Testing

  • Unit test added
  • Manually tested

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 86.30%. Comparing base (a8e81d7) to head (6e9c970).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/git/git.go 0.00% 14 Missing ⚠️
cloud/deploy/bundle.go 75.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1677      +/-   ##
==========================================
- Coverage   86.31%   86.30%   -0.01%     
==========================================
  Files         116      116              
  Lines       17052    17055       +3     
==========================================
+ Hits        14719    14720       +1     
- Misses       1403     1406       +3     
+ Partials      930      929       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeremybeard jeremybeard merged commit 457c026 into main Jul 18, 2024
3 of 5 checks passed
@jeremybeard jeremybeard deleted the bundle-description-commit-message branch July 18, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants