Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run approval & new tag jobs only after lint & test are passing #1700

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

neel-astro
Copy link
Contributor

Description

Fix the order of jobs in CI when creating a new release. One can approve and build the release even if linting or unit tests are failing. This PR fixes that to block the release workflow if lint/test jobs are failing

Existing Workflow:
image

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@neel-astro neel-astro merged commit 2a30180 into main Aug 12, 2024
3 checks passed
@neel-astro neel-astro deleted the fix/release-ci-order branch August 12, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants