-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workload identity to hosted deployment #1708
Conversation
tickNum = 10 | ||
timeoutNum = 180 | ||
listLimit = 1000 | ||
dedicatedDeploymentRequest = astroplatformcore.UpdateDedicatedDeploymentRequest{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dropped the global variable, this makes no difference from CLI functionality pov, but it messes up the unit tests, since the global variables are shared
MockResponseInit() | ||
} | ||
|
||
func (s *Suite) TearDownSubTest() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the state leak issue between unit tests from #1698, I had to do this bit here because otherwise, the existing unit tests were making it almost impossible to write new unit tests, and it took me 3 hours to write a single update deployment test scenario in this file 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: kushalmalani <kushal@astronomer.io>
Co-authored-by: kushalmalani <kushal@astronomer.io>
Description
Changes:
astro deployment create
andastro deployment update
commands for dedicated and standard deploymentsastro deployment --deployment-file
for dedicated and standard deployments🎟 Issue(s)
Related #1704
🧪 Functional Testing
astro deployment create
case with workload identity flagastro deployment update
case with workload identity flagastro deployment
case for deployments running on azure/gcpastro deployment create
case using a deployment yaml fileastro deployment update
case using a deployment yaml file📸 Screenshots
📋 Checklist
make test
before taking out of draftmake lint
before taking out of draft