Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for azure deployment creation #1718

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Conversation

pritt20
Copy link
Contributor

@pritt20 pritt20 commented Sep 12, 2024

Description

As we have changed the default cloud provider to Azure for deployments on standard cluster. We would also like to have same behaviour on Astro-cli end. Currently, we have default cloud-provider set to gcp in Astro-cli. As part of this PR changes, we are updating default cloud-provider to azure to be in sync with UI.

🎟 Issue(s)

closes #1707

🧪 Functional Testing

Tested the changes by creating default deployment on PR-preview environment using Astro-CLI build with these changes:

./astro deployment create
                                                                         
Current Workspace: Sample Workspace 2

Please specify a name for your Deployment

Deployment name: test-cli

Please select a Region for your Deployment:
 #     REGION         
 1     eastus2        
 2     westeurope     
 3     westus2        

> 2
 NAME         NAMESPACE                     CLUSTER     CLOUD PROVIDER     REGION         DEPLOYMENT ID                 RUNTIME VERSION                      DAG DEPLOY ENABLED     CI-CD ENFORCEMENT     DEPLOYMENT TYPE     
 test-cli     asteroidal-telemetry-9312     N/A         AZURE              westeurope     cm0zkgbag00a401nhf2is3wus     12.1.0 (based on Airflow 2.10.1)     true                   false                 STANDARD            

 Successfully created Deployment: test-cli
 Deployment can be accessed at the following URLs 

 Deployment Dashboard: cloud.astronomer-dev.io/cm0wad7pq0108f7j2he7990qn/deployments/cm0zkgbag00a401nhf2is3wus/overview
 Airflow Dashboard: sampleorgpr23859-pr23859.astronomer-dev.run/d2is3wus?orgId=org_TpYkP1OnRzcNzN8r

📸 Screenshots

image

image

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@pritt20 pritt20 requested review from schnie and chomipi88 September 13, 2024 10:55
@pritt20 pritt20 marked this pull request as ready for review September 13, 2024 10:59
Copy link
Contributor

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a minor comments, but thanks for making the change 🚀

cmd/cloud/deployment.go Show resolved Hide resolved
Copy link
Contributor

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schnie
Copy link
Member

schnie commented Sep 17, 2024

@pritt20 @neel-astro as discussed in the PLG slack channel thread, we probably want to document this as a breaking change since it has the potential to cause a change in behavior. cc @chomipi88

@neel-astro neel-astro merged commit a5c906a into main Sep 27, 2024
3 checks passed
@neel-astro neel-astro deleted the add_azure_support branch September 27, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Azure Hosted Deployment creation
4 participants