Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Podman Container Runtime #1750

Merged
merged 20 commits into from
Dec 11, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion airflow/runtimes/container_runtime.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ const (
// the container runtime lifecycle.
type ContainerRuntime interface {
Initialize() error
Configure() error
ConfigureOrKill() error
Kill() error
Comment on lines +34 to +36
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding 3 new lifecycle methods here. The airflow hooks call these methods depending on the situation.

}

// GetContainerRuntime creates a new container runtime based on the runtime string
Expand Down Expand Up @@ -83,7 +86,7 @@ func FindBinary(pathEnv, binaryName string, checker FileChecker) bool {

// Although programs can be called without the .exe extension,
// we need to append it here when searching the file system.
if isWindows() {
if IsWindows() {
binaryName += ".exe"
}

Expand Down
12 changes: 12 additions & 0 deletions airflow/runtimes/docker_runtime.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,15 @@ func (p DockerRuntime) Initialize() error {
}
return InitializeDocker(new(DefaultDockerInitializer), defaultTimeoutSeconds)
}

func (p DockerRuntime) Configure() error {
return nil
}

func (p DockerRuntime) ConfigureOrKill() error {
return nil
}

func (p DockerRuntime) Kill() error {
return nil
}
Loading