-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade golangci-lint to v1.62.2 #1756
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a minor nit around pkg/errors
vs fmt.Errorf
, but approving ahead of time,
@@ -210,8 +210,8 @@ func (d *DockerImage) Pytest(pytestFile, airflowHome, envFile, testHomeDirectory | |||
|
|||
// start pytest container | |||
err = cmdExec(containerRuntime, stdout, stderr, []string{"start", "astro-pytest", "-a"}...) | |||
if docErr != nil { | |||
log.Debugf("Error starting pytest container: %s", docErr.Error()) | |||
if err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch 👍
airflow/runtimes/docker_runtime.go
Outdated
@@ -68,15 +68,15 @@ func (rt DockerRuntime) initializeDocker(timeoutSeconds int) error { | |||
// If we got an error, Docker is not running, so we attempt to start it. | |||
_, err = rt.Engine.Start() | |||
if err != nil { | |||
return fmt.Errorf(dockerOpenNotice) //nolint:stylecheck | |||
return errors.New(dockerOpenNotice) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we should stay with fmt.Errorf
I think, since pkg/errors
is deprecated now, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can change this instance from github.com/pkg/errors
to errors
?
We might want a separate cleanup PR at some point to remove github.com/pkg/errors
completely from the CLI, I see many instances of it, and in ways that can't be transparently switched to errors
.
Description
This change upgrades the golangci-lint dependency to the latest version so that it can support Go 1.23, which the CLI is also upgraded to. The corresponding linting errors are then also fixed.
📸 Screenshots
📋 Checklist
make test
before taking out of draftmake lint
before taking out of draft