Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix ruff issues #2172

Merged
merged 2 commits into from
Jun 21, 2024
Merged

style: fix ruff issues #2172

merged 2 commits into from
Jun 21, 2024

Conversation

Lee-W
Copy link
Collaborator

@Lee-W Lee-W commented Jun 21, 2024

No description provided.

@Lee-W Lee-W requested a review from a team June 21, 2024 07:28
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.11%. Comparing base (e5f5e82) to head (6d0e10a).

Current head 6d0e10a differs from pull request most recent head e00ad6e

Please upload reports for the commit e00ad6e to get more accurate results.

Files Patch % Lines
python-sdk/src/astro/databases/duckdb.py 0.00% 2 Missing ⚠️
python-sdk/src/astro/databases/sqlite.py 0.00% 2 Missing ⚠️
python-sdk/src/astro/databases/snowflake.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2172      +/-   ##
==========================================
- Coverage   90.24%   89.11%   -1.14%     
==========================================
  Files          75       75              
  Lines        4316     4318       +2     
  Branches      538      538              
==========================================
- Hits         3895     3848      -47     
- Misses        318      367      +49     
  Partials      103      103              
Flag Coverage Δ
PythonSDK 89.11% <16.66%> (-1.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lee-W Lee-W merged commit 33ca675 into main Jun 21, 2024
30 checks passed
@Lee-W Lee-W deleted the fix-ruff branch June 21, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants