Unpin SQLAlchemy & sqlalchemy-bigquery #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
force-pushed
the
unpin-sqlalchemy-libs
branch
6 times, most recently
from
1ace8d9
to
91269f1
Compare
Codecov Report
@@ Coverage Diff @@
## main #367 +/- ##
==========================================
+ Coverage 93.01% 93.04% +0.02%
==========================================
Files 56 57 +1
Lines 1962 1969 +7
Branches 303 302 -1
==========================================
+ Hits 1825 1832 +7
Misses 100 100
Partials 37 37
Continue to review full report at Codecov.
|
tatiana
approved these changes
May 19, 2022
This commit unpins `SQLAlchemy` and `sqlalchemy-bigquery` dependency so we can use it with Airflow 2.3
kaxil
force-pushed
the
unpin-sqlalchemy-libs
branch
from
91269f1
to
b40a28f
Compare
kaxil
added a commit
that referenced
this pull request
May 19, 2022
This commit unpins `SQLAlchemy` and `sqlalchemy-bigquery` dependency so we can use it with Airflow 2.3. This PR also fixes the Sqlite issues that we were hacking around with quotes. I have also created a companion PR in Airflow: apache/airflow#23790 . Once this PR is merged and release, we can bump the Sqlite Provider and remove the logic of `get_uri` from this repo. closes #351 (cherry picked from commit ba4e6bd)
kaxil
added a commit
that referenced
this pull request
May 20, 2022
Uses https://docs.pytest.org/en/latest/how-to/usage.html#profiling-test-execution-duration to get a list of slowest 30 tests for which the durations is over 1.0s long. This is a small change but will help identify if a test takes too long. Found a need to do that while working on #367 and #370
kaxil
added a commit
that referenced
this pull request
May 22, 2022
This commit unpins `SQLAlchemy` and `sqlalchemy-bigquery` dependency so we can use it with Airflow 2.3. This PR also fixes the Sqlite issues that we were hacking around with quotes. I have also created a companion PR in Airflow: apache/airflow#23790 . Once this PR is merged and release, we can bump the Sqlite Provider and remove the logic of `get_uri` from this repo. closes #351
kaxil
added a commit
that referenced
this pull request
May 22, 2022
Uses https://docs.pytest.org/en/latest/how-to/usage.html#profiling-test-execution-duration to get a list of slowest 30 tests for which the durations is over 1.0s long. This is a small change but will help identify if a test takes too long. Found a need to do that while working on #367 and #370
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit unpins
SQLAlchemyandsqlalchemy-bigquerydependency so we can use it with Airflow 2.3.This PR also fixes the Sqlite issues that we were hacking around with quotes. I have also created a companion PR in Airflow: apache/airflow#23790 . Once this PR is merged and release, we can bump the Sqlite Provider and remove the logic of
get_urifrom this repo.closes #351