Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column capitalization #565

Closed
wants to merge 10 commits into from
Closed

Column capitalization #565

wants to merge 10 commits into from

Conversation

utkarsharma2
Copy link
Collaborator

Description

What is the current behavior?

To achieve a first end-to-end delivery of the Snowflake optimization:
#487
#544

There was an assumption that to avoid issues with Snowflake mixed-capitalized column names, it was acceptable to convert all characters to uppercase.

  1. it is not consistent with the dataframe decorator parameter: identifiers_as_lower
    
  2. it does not support the use case where users may prefer to convert everything to uppercase
    

closes: #564

What is the new behavior?

The goal with this ticket is to add the following argument to both aql.dataframe and aql.load_file (snowflake-only), removing the previous identifiers_as_lower parameter:

columns_names_capitalization=["upper", "lower", "original"]

Checklist

  • Replace the aql.dataframe argument identifiers_as_lower by columns_names_capitalization
  • Add support for columns_names_capitalization when using load_file to Snowflake
  • Have tests covering these scenarios
  • Update release notes

@utkarsharma2
Copy link
Collaborator Author

Duplicate PR.

@kaxil kaxil deleted the ColumnCapitalization branch August 18, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support customization of column titles capitalization when using dataframe & load_file
2 participants