Fix DistutilsOptionError #570 #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File "/home/runner/work/astro-sdk/astro-sdk/.nox/type_check-3-8/lib/python3.8/site-packages/setuptools/config/pyprojecttoml.py", line 301, in _ensure_previously_set
raise OptionError(msg)
distutils.errors.DistutilsOptionError: No configuration found for dynamic 'description'.
Some dynamic fields need to be specified via `tool.setuptools.dynamic`
others must be specified via the equivalent attribute in `setup.py`.
[end of output]
pankajastro
approved these changes
Jul 26, 2022
sunank200
approved these changes
Jul 26, 2022
| @@ -36,6 +36,7 @@ jobs: | |||
| env: | |||
| MYPY_FORCE_COLOR: 1 | |||
| TERM: xterm-color | |||
| SETUPTOOLS_USE_DISTUTILS: stdlib | |||
There was a problem hiding this comment.
What does this line do? Just for my knowledge.
There was a problem hiding this comment.
@sunank200 I believe this comment explains the key issue:
pypa/setuptools#2965 (comment)
The way the distutils hack works, it makes Setuptools' own copy of distutils take precedence over the standard library, so causes import distutils to put sys.modules['distutils'] = <setuptools._distutils>. So it's not a big surprise to me that running the tests from the standard library against code not in the standard library will have problems.
More information in the official docs:
https://setuptools.pypa.io/en/latest/deprecated/distutils-legacy.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-with: @uranusjr
Fix: #570
Aims to solve this issue in the CI: