Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DbtTaskGroup should not need dag=dag #118

Closed
denimalpaca opened this issue Feb 3, 2023 · 0 comments · Fixed by #119 or #126
Closed

DbtTaskGroup should not need dag=dag #118

denimalpaca opened this issue Feb 3, 2023 · 0 comments · Fixed by #119 or #126

Comments

@denimalpaca
Copy link
Contributor

Like other task groups, if using the dag context manager, the DbtTaskGroup shouldn't need the dag=dag argument passed in.
josh-fell added a commit to josh-fell/astronomer-cosmos that referenced this issue Feb 4, 2023
@josh-fell
Make dag arg optional for CosmosTaskGroup
4e278ed 
Closes: astronomer#118

Typically when authoring with TaskGroups in Airflow, users will not explicitly pass a DAG object but rather set the TaskGroup within a DAG context manager. Making the `dag` arg optional in the CosmosTaskGroup will allow the same authoring practice. In Airflow, if a `dag` arg is not passed to a TaskGroup, behind the scenes `DagContext.get_current_dag()` is called to retrieve the DAG object. Since CosmosTaskGroup pushes the `dag` arg to its super class, and early enough in construction, the same functional behavior is triggered.
josh-fell added a commit to josh-fell/astronomer-cosmos that referenced this issue Feb 4, 2023
@josh-fell
Make dag arg optional for CosmosTaskGroup
f99fa7d 
Closes: astronomer#118

Typically when authoring with TaskGroups in Airflow, users will not explicitly pass a DAG object but rather set the TaskGroup within a DAG context manager. Making the `dag` arg optional in the CosmosTaskGroup will allow the same authoring practice. In Airflow, if a `dag` arg is not passed to a TaskGroup, behind the scenes `airflow.models.DagContext.get_current_dag()` is called to retrieve the DAG object. Since CosmosTaskGroup pushes the `dag` arg to its super class, and early enough in construction, the same functional behavior is triggered.
@josh-fell josh-fell mentioned this issue Feb 4, 2023
Merged
chrishronek added a commit that referenced this issue Feb 6, 2023
@josh-fell @chrishronek
Make dag arg optional for CosmosTaskGroup (#119)
0818719 
Closes: #118

Typically when authoring with TaskGroups in Airflow, users will not
explicitly pass a DAG object but rather set the TaskGroup within a DAG
context manager. Making the `dag` arg optional in the CosmosTaskGroup
will allow the same authoring practice. In Airflow, if a `dag` arg is
not passed to a TaskGroup, behind the scenes
`airflow.models.DagContext.get_current_dag()` is called to retrieve the
DAG object. Since CosmosTaskGroup pushes the `dag` arg to its super
class, and early enough in construction, the same functional behavior is
triggered.

Co-authored-by: Chris Hronek <31361051+pohek321@users.noreply.github.com>
josh-fell added a commit to josh-fell/astronomer-cosmos that referenced this issue Feb 6, 2023
@josh-fell
Make dag arg optional for CosmosTaskGroup
15d01fa 
Closes: astronomer#118

Typically when authoring with TaskGroups in Airflow, users will not explicitly pass a DAG object but rather set the TaskGroup within a DAG context manager. Making the `dag` arg optional in the CosmosTaskGroup will allow the same authoring practice. In Airflow, if a `dag` arg is not passed to a TaskGroup, behind the scenes `airflow.models.DagContext.get_current_dag()` is called to retrieve the DAG object. Since CosmosTaskGroup pushes the `dag` arg to its super class, and early enough in construction, the same functional behavior is triggered.
@josh-fell josh-fell mentioned this issue Feb 6, 2023
Merged
josh-fell added a commit to josh-fell/astronomer-cosmos that referenced this issue Feb 6, 2023
@josh-fell
Make dag arg optional for CosmosTaskGroup
2cade25 
Closes: astronomer#118

Typically when authoring with TaskGroups in Airflow, users will not explicitly pass a DAG object but rather set the TaskGroup within a DAG context manager. Making the `dag` arg optional in the CosmosTaskGroup will allow the same authoring practice. In Airflow, if a `dag` arg is not passed to a TaskGroup, behind the scenes `airflow.models.DagContext.get_current_dag()` is called to retrieve the DAG object. Since CosmosTaskGroup pushes the `dag` arg to its super class, and early enough in construction, the same functional behavior is triggered.
chrishronek pushed a commit that referenced this issue Feb 6, 2023
@josh-fell
Make dag arg optional for CosmosTaskGroup (#126)
7a18d93 
Closes: #118

Typically when authoring with TaskGroups in Airflow, users will not
explicitly pass a DAG object but rather set the TaskGroup within a DAG
context manager. Making the `dag` arg optional in the CosmosTaskGroup
will allow the same authoring practice. In Airflow, if a `dag` arg is
not passed to a TaskGroup, behind the scenes
`airflow.models.DagContext.get_current_dag()` is called to retrieve the
DAG object. Since CosmosTaskGroup pushes the `dag` arg to its super
class, and early enough in construction, the same functional behavior is
triggered.
@dosubot dosubot bot mentioned this issue Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@denimalpaca