ProfileMapping profile_args should raise a warning if they override mapped_params

[jbandoro]

This issue was found in the Slack thread here where the user was using the GoogleCloudServiceAccountDictProfileMapping with the profile_args similar to:

profile_config = ProfileConfig(
        profile_name="default",
        target_name="dev",
        profile_mapping=GoogleCloudServiceAccountDictProfileMapping(
            conn_id="google_cloud_connection",
            profile_args={"method": "service_account"},
        ),
)

This would result in the dbt_profile_method class var that is mapped to dbt profile fields below:

astronomer-cosmos/cosmos/profiles/base.py

Lines 199 to 211 in d28d3df

	def mapped_params(self) -> dict[str, Any]:
	"Turns the self.airflow_param_mapping into a dictionary of dbt fields and their values."
	mapped_params = {
	"type": self.dbt_profile_type,
	}
	if self.dbt_profile_method:
	mapped_params["method"] = self.dbt_profile_method
	for dbt_field in self.airflow_param_mapping:
	mapped_params[dbt_field] = self.get_dbt_value(dbt_field)
	return mapped_params

to then be replaced when the profile is created below:

https://github.com/astronomer/astronomer-cosmos/blob/d28d3df7eacac74d0fbb016be70434bcc30c51be/cosmos/profiles/bigquery/service_account_keyfile_dict.py#L48C16-L52C10

because the merging of dictionaries with profile_args={"method": "service_account"} will replace the mapped_params that has {"method": ""service-account-json""}.

This issue is not limited to GoogleCloudServiceAccountDictProfileMapping and can happen with all of the profiles where there is overlap in the mapped params and the user provided profile args.

Cosmos should raise a warning if this happens to warn the user that they are replacing a cosmos mapped parameter.

[dosubot]

🤖

Hi @jbandoro,

Great to see you again! I hope you're doing well. I appreciate you bringing this issue to our attention. I'm diving into it right now and will follow up with a more comprehensive answer shortly. Thanks for your patience.

[dosubot]

🤖

It seems like you've got this under control, if you want help or have specific questions, let me know what I can do for you!

---

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.