Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Dbt docs operator should not look for graph.gpickle file when --no-write-json is passed. #882

Closed
dwreeves opened this issue Mar 8, 2024 · 1 comment · Fixed by #883
Closed

[Bug] Dbt docs operator should not look for graph.gpickle file when --no-write-json is passed. #882

dwreeves opened this issue Mar 8, 2024 · 1 comment · Fixed by #883
Labels
area:docs Relating to documentation, changes, fixes, improvement dbt:docs Primarily related to dbt docs command or functionality execution:local Related to Local execution environment

Comments

@dwreeves
Copy link
Collaborator

dwreeves commented Mar 8, 2024

TLDR: --no-write-json prevents writing the graph.gpickle file. When this flag is there, that file should not be looked for.

Strictly speaking, graph.gpickle is not actually necessary for the dbt docs, so there is no harm to users who need to generate docs in respecting the --no-write-json flag.
@dosubot DosuBot
Copy link

dosubot bot commented Mar 8, 2024 •
edited
Loading

It seems like you've got this under control, if you want help or have specific questions, let me know what I can do for you!

About Dosu

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@dosubot dosubot bot added area:docs Relating to documentation, changes, fixes, improvement dbt:docs Primarily related to dbt docs command or functionality execution:local Related to Local execution environment labels Mar 8, 2024
@dwreeves dwreeves mentioned this issue Mar 9, 2024
Merged
tatiana added a commit that referenced this issue Mar 21, 2024
@dwreeves @tatiana
[Bugfix] Dbt docs operator should not look for graph.gpickle file w…
4e3a3c8 
…hen `--no-write-json` is passed. (#883)

Fixes #882

---------

Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
arojasb3 pushed a commit to arojasb3/astronomer-cosmos that referenced this issue Jul 14, 2024
@dwreeves @tatiana @arojasb3
[Bugfix] Dbt docs operator should not look for graph.gpickle file w…
8d9eb62 
…hen `--no-write-json` is passed. (astronomer#883)

Fixes astronomer#882

---------

Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:docs Relating to documentation, changes, fixes, improvement dbt:docs Primarily related to dbt docs command or functionality execution:local Related to Local execution environment
Projects
None yet
Milestone
No milestone
1 participant
@dwreeves