Add Oracle to airflow->cosmos profile map #1190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
dosubot
bot
added
the
area:profile
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1190 +/- ##
==========================================
- Coverage 95.72% 95.43% -0.30%
==========================================
Files 64 67 +3
Lines 3672 3788 +116
==========================================
+ Hits 3515 3615 +100
- Misses 157 173 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pankajkoti
reviewed
Sep 19, 2024
pankajastro
reviewed
Sep 23, 2024
|
Working on that. Should have something in the next few days. |
|
Hi @slords, thanks a lot for working on this feature! |
…#1221) This adds a privacy notice and website analytics to the Cosmos readme and auto-generated docs. Note that while you cannot explicitly opt out of website analytics for the publicly hosted readme (and docs), Scarf respects browser DND. If that is set via the browser, telemetry for that user will not be sent to Scarf. Scarf privacy policy: https://about.scarf.sh/privacy-policy Astronomer privacy policy: https://www.astronomer.io/privacy/
Added new `GCP_CLOUD_RUN_JOB` execution mode that triggers Google Cloud Platform's Cloud Run Job instance with dbt model in it. It extends Airflow's `CloudRunExecuteJobOperator` and overrides Cloud Run Job's container with dbt command generated by cosmos. Note: `CloudRunExecuteJobOperator` has `container_overrides` parameter implemented in `apache-airflow-providers-google==10.13.0` which is supported by `airflow >=2.6.0`. Resolves astronomer#1149 Co-authored-by: Agata Zalewska <azalewska5@grupazpr.pl> Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
…1198) In projects containing models with names like the following, dataset creation fails, and an error occurs during execution. ```txt └── dbt └── my_project └── models ├── 日本語名モデル.sql └── 日本語名モデル.yml ``` ``` File "/home/airflow/.local/lib/python3.12/site-packages/airflow/datasets/__init__.py", line 78, in _sanitize_uri raise ValueError("Dataset URI must only consist of ASCII characters") ValueError: Dataset URI must only consist of ASCII characters ``` To support model names with multibyte characters, it might be good to URL encode the names. closes: astronomer#1197 Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
dosubot
bot
added
size:XXL
|
Hey @slords, we're really close to completing this feature - it would be great to release it as part of Cosmos 1.8. Please, do let us know if you'd like any additional support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the ability to map Oracle connections from airflow to comsos
Related Issue(s)
closes #1189
Breaking Change?
None that I'm aware of.
Checklist