-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add task timeout support. #1317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. Can we show an example of this in one of the DAGs and potentially also mention about it somewhere in our docs?
Hi @pankajkoti , |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1317 +/- ##
=======================================
Coverage 96.02% 96.02%
=======================================
Files 67 67
Lines 4025 4028 +3
=======================================
+ Hits 3865 3868 +3
Misses 160 160 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. some minor suggestion inline. Thanks for dropping the SLA piece. Could you please also update the PR title & description to drop SLA & additionally reflect the renamed config key cosmos_task_timeout
?
We could merge this once these minor changes are addressed & meantime hopefully @tatiana and/or @pankajastro could also get a chance to review this PR.
I believe the interface for this task will change depending on the outcomes of the discussion we're having in #1339 |
Thank you very much for the contribution, @t0momi219 ! Since #1339 has a more generic implementation, it supports the same behaviour but by using a more extensible interface:
Therefore, I'm closing this PR. |
Description
In Airflow, both DAGs and tasks can have timeout specified. Since dbt models likely have varying expected execution times for each layer, there could be cases where users want to apply timeout individually to each node.
How about having Cosmos retrieve timeout from the node metadata and apply them individually when rendering nodes?
Specifically, the expected time is specified in the model's config, which will be read accordingly.
Related Issue(s)
closes #1316
Breaking Change?
Checklist