Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds profile_config for Docker #1347

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

andrewhlui
Copy link
Contributor

@andrewhlui andrewhlui commented Nov 27, 2024

Description

Adds ProfileConfig to Docker operators so that people can use TaskGroups.

Related Issue(s)

Closes #1346

Breaking Change?

Checklist

  • I have made corresponding changes to the documentation (if required)
  • I have added tests that prove my fix is effective or that my feature works

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 27, 2024
@dosubot dosubot bot added area:execution Related to the execution environment/mode, like Docker, Kubernetes, Local, VirtualEnv, etc area:profile Related to ProfileConfig, like Athena, BigQuery, Clickhouse, Spark, Trino, etc labels Nov 27, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.29%. Comparing base (0edb07d) to head (3629068).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1347   +/-   ##
=======================================
  Coverage   96.28%   96.29%           
=======================================
  Files          68       68           
  Lines        4150     4152    +2     
=======================================
+ Hits         3996     3998    +2     
  Misses        154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a unit test to avoid regression?

Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andrewhlui, thanks a lot for your contribution!

Some requests:

  1. Please add a test for this feature
  2. If possible, update the docs, mentioning any limitations of this feature (comment inline)

If you can address this before 20 December, we can release this feature as part of Cosmos 1.8

cosmos/operators/docker.py Show resolved Hide resolved
@tatiana tatiana added this to the Cosmos 1.8.0 milestone Dec 10, 2024
@tatiana tatiana requested a review from pankajastro December 12, 2024 12:05
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Dec 18, 2024
@andrewhlui
Copy link
Contributor Author

Hi @andrewhlui, thanks a lot for your contribution!

Some requests:

  1. Please add a test for this feature
  2. If possible, update the docs, mentioning any limitations of this feature (comment inline)

If you can address this before 20 December, we can release this feature as part of Cosmos 1.8

Added some tests, let me know if this works.

Copy link
Contributor

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a note about supporting profile_config with profiles.yml way and not ProfileMapping way in the docs at https://astronomer.github.io/astronomer-cosmos/getting_started/execution-modes.html#docker

The source for the docs are located at https://github.com/astronomer/astronomer-cosmos/blob/main/docs/getting_started/execution-modes.rst#docker

IMO, we're good to merge once these suggestions are addressed

cosmos/operators/docker.py Show resolved Hide resolved
@pankajkoti pankajkoti self-assigned this Dec 19, 2024
@pankajkoti
Copy link
Contributor

In the interest of time, I have tried to address my review comments in PR #1413. If those look good, perhaps we can merge this PR and rebase my PR

cc: @tatiana @andrewhlui

@andrewhlui
Copy link
Contributor Author

In the interest of time, I have tried to address my review comments in PR #1413. If those look good, perhaps we can merge this PR and rebase my PR

cc: @tatiana @andrewhlui

I won't have time to work on this for the next week -- so that approach sounds good to me.
Thank you!

@pankajkoti pankajkoti force-pushed the alui/docker-profile-config branch from 3629068 to 99672af Compare December 20, 2024 06:54
@pankajkoti pankajkoti merged commit 3b92421 into astronomer:main Dec 20, 2024
28 of 29 checks passed
pankajkoti added a commit that referenced this pull request Dec 20, 2024
…tionMode.Docker (#1413)

This PR addresses the open review comments on PR #1347 which adds
profile_config to Docker execution mode.

related: #1346 
related: #1347

---------

Co-authored-by: Andrew Lui <andrew.lui@gusto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:execution Related to the execution environment/mode, like Docker, Kubernetes, Local, VirtualEnv, etc area:profile Related to ProfileConfig, like Athena, BigQuery, Clickhouse, Spark, Trino, etc size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Docker Execution doesn't work with Task Groups
4 participants