Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to consolidate async dbt adapter code #1509

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pankajkoti
Copy link
Contributor

@pankajkoti pankajkoti commented Feb 5, 2025

This PR addresses the feedback in PR #1474 suggesting to consolidate dbt adapter methods
in the _asynchronous module and additionally avoiding keeping dictionary type maps for adapter
callables.

closes: #1508

Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for sunny-pastelito-5ecb04 canceled.

Name Link
🔨 Latest commit d84e9fb
🔍 Latest deploy log https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/67a33fb8390500000894cd0f

Copy link

Deploying astronomer-cosmos with  Cloudflare Pages  Cloudflare Pages

Latest commit: d84e9fb
Status: ✅  Deploy successful!
Preview URL: https://e0a0854a.astronomer-cosmos.pages.dev
Branch Preview URL: https://refactor-bq-adapter-methods.astronomer-cosmos.pages.dev

View logs

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.31%. Comparing base (24108f0) to head (d84e9fb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1509   +/-   ##
=======================================
  Coverage   97.31%   97.31%           
=======================================
  Files          79       78    -1     
  Lines        4616     4621    +5     
=======================================
+ Hits         4492     4497    +5     
  Misses        124      124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pankajkoti pankajkoti marked this pull request as ready for review February 5, 2025 11:02
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. profile:bigquery Related to BigQuery ProfileConfig labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profile:bigquery Related to BigQuery ProfileConfig size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor dbt adapter mocking modules
1 participant