Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all databricks files since we now have a separate databricks provider #189

Merged
merged 4 commits into from
Mar 17, 2023

Conversation

dimberman
Copy link
Contributor

@dimberman dimberman commented Mar 16, 2023

Now that we have the https://github.com/astronomer/astro-provider-databricks, we no longer need to keep any of our databricks code in cosmos. This will simplify the process of converting cosmos to astro-provider-dbt for future releases and reduce any potential confusion by users.

Closes #186

@dimberman dimberman requested a review from a team as a code owner March 16, 2023 20:28
@dimberman dimberman linked an issue Mar 16, 2023 that may be closed by this pull request
@jensenity
Copy link

Hi @dimberman, I'm trying to contribute dbt-spark adapter on cosmos but the test codes for databricks kept failing. And found that the profile_test.py is not being tested as well. Is this related to this PR since databricks is being moved to a different repo?

@dimberman
Copy link
Contributor Author

Hi @jensenity this shouldn't be related to the databricks-dbt stuff at all. This is moving all code related to the DatabricksWorlfowTaskGroup (which allows users to run databricks jobs on Airflow) to a different repo. Can you please send me your PR and I can see why the databricks tests are failing for you?

Copy link
Contributor

@chrishronek chrishronek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved whenever you are ready @dimberman

@dimberman dimberman merged commit b3e5ffe into main Mar 17, 2023
@dimberman dimberman deleted the remove-databricks branch March 17, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Databricks work from this repo
3 participants