Change the key of the GCP service account keyfile #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrishronek
suggested changes
Mar 24, 2023
chrishronek
added
bug
chrishronek
approved these changes
Mar 27, 2023
|
@mmenalla, tysm for this contribution! I'm going to go ahead and merge it and it'll be included on our next release (which is hopefully going out today). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Airflow version 2.4.2 connection generates a key_file with the key named "extra__google_cloud_platform__keyfile_dict" while the create_profile_vars_google_cloud_platform() function tries to access it with the keyword "keyfile_dict", which was used in older Airflow versions.