Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for K8s and Docker operators usage #229

Merged
merged 5 commits into from
Apr 12, 2023
Merged

Add docs for K8s and Docker operators usage #229

merged 5 commits into from
Apr 12, 2023

Conversation

pankajkoti
Copy link
Contributor

@pankajkoti pankajkoti commented Apr 11, 2023 •
edited
Loading

The PR adds steps by step instruction tutorial demonstrating example DAGs and setup required to run the DBT Docker and Kubernetes operators that are introduced in PR #194

@pankajkoti pankajkoti marked this pull request as ready for review April 11, 2023 18:55
@pankajkoti pankajkoti requested a review from a team as a code owner April 11, 2023 18:55
@pankajkoti
Copy link
Contributor Author

Screenshots of the built docs

Kubernetes
k8s

Docker
docker

jlaneve
jlaneve reviewed Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@jlaneve jlaneve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two notes:

  • can we make sure "dbt" is lowercase everywhere (not "Dbt" or "DBT") - that's the official spelling
  • can we rename this section to "Other execution options" and stack the sections on top of each other instead of using tabs?

@pankajkoti pankajkoti requested a review from jlaneve April 12, 2023 04:35
@pankajkoti
Copy link
Contributor Author

@jlaneve I have addressed your comments. The section appears now as per the screenshot:
Other execution options

@jlaneve jlaneve merged commit 5ee6ce4 into main Apr 12, 2023
@jlaneve jlaneve deleted the docker-k8s-operators-docs branch April 12, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaneve jlaneve jlaneve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pankajkoti @jlaneve