Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the default value for the dbt_root_path #256

Merged
merged 4 commits into from
Apr 28, 2023
Merged

Conversation

chrishronek
Copy link
Contributor

This has been throwing a lot of customers off ever since we changed the dbt parent to be within /dags. Proposing that we change the default to match our docs.

@chrishronek chrishronek added the enhancement New feature or request label Apr 26, 2023
@chrishronek chrishronek requested a review from a team as a code owner April 26, 2023 20:58
@chrishronek chrishronek self-assigned this Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e67bcbc) 78.74% compared to head (0725cb1) 78.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #256   +/-   ##
=======================================
  Coverage   78.74%   78.74%           
=======================================
  Files          28       28           
  Lines        1002     1002           
=======================================
  Hits          789      789           
  Misses        213      213           
Impacted Files Coverage Δ
cosmos/providers/dbt/dag.py 75.00% <ø> (ø)
cosmos/providers/dbt/render.py 94.50% <ø> (ø)
cosmos/providers/dbt/task_group.py 75.00% <ø> (ø)
cosmos/__init__.py 100.00% <100.00%> (ø)
cosmos/providers/dbt/parser/project.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jlaneve
Copy link
Collaborator

jlaneve commented Apr 26, 2023

Nice! Do we need any docs changes here?

@chrishronek
Copy link
Contributor Author

chrishronek commented Apr 28, 2023

Nice! Do we need any docs changes here?

I don't think so! Actually, we do. Committed

@jlaneve jlaneve merged commit 7df2b1d into main Apr 28, 2023
@jlaneve jlaneve deleted the update-default-path branch April 28, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants