add exposure enum to dbtresourcetype #470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #470 +/- ##
=======================================
Coverage 91.78% 91.79%
=======================================
Files 50 50
Lines 1790 1791 +1
=======================================
+ Hits 1643 1644 +1
Misses 147 147
☔ View full report in Codecov by Sentry. |
tatiana
reviewed
Aug 15, 2023
There was a problem hiding this comment.
Thanks, @mike-winkel , this is very helpful! Please, please add a test covering the breaking behavior before introducing this new resource type?
|
Hey @mike-winkel , would you like support testing this feature? Your contribution is very valuable, and we'd love to merge it |
|
This change is a subset of #503, so we are closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add exposures as a type of dbt node in the DbtResourceType class.
This adds no useful functionality to the repository aside from it not crashing when exposures config is added into dbt projects (used for data lineage).