Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in S3KeysUnchangedTrigger and is_key_unchanged in hook #109

Merged
merged 6 commits into from
Mar 10, 2022

Conversation

sunank200
Copy link
Collaborator

  • Fix the bug on S3KeysUnchangedTrigger and is_key_unchanged

Closes : #108

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #109 (fe5168b) into main (974331d) will increase coverage by 0.49%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   94.76%   95.26%   +0.49%     
==========================================
  Files          35       35              
  Lines        1892     1899       +7     
==========================================
+ Hits         1793     1809      +16     
+ Misses         99       90       -9     
Impacted Files Coverage Δ
astronomer/providers/amazon/aws/hooks/s3.py 100.00% <100.00%> (+5.04%) ⬆️
astronomer/providers/amazon/aws/triggers/s3.py 100.00% <100.00%> (+1.75%) ⬆️
astronomer/providers/amazon/aws/sensors/s3.py 100.00% <0.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 974331d...fe5168b. Read the comment docs.

@phanikumv phanikumv merged commit 2111363 into main Mar 10, 2022
@phanikumv phanikumv deleted the fix-s3-keys-unchanged-trigger branch March 10, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3KeysUnchangedTrigger run method on infinite loop
2 participants