Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sphinx to autogenerate user-facing docs #114

Merged
merged 14 commits into from
Mar 15, 2022
Merged

Add Sphinx to autogenerate user-facing docs #114

merged 14 commits into from
Mar 15, 2022

Conversation

sunank200
Copy link
Collaborator

Use Sphinx and Sphinx auto-api extension to autogenerate docs to achieve the following:

  • Better discoverability of the available Async Operators, Sensors and Hooks
  • Allows us to document the limitations of certain async operators
  • Add better compatibility matrix of Airflow and astronomer-providers package.
  • Better Document versioning if we host it to ReadTheDocs

closes: #64

@kaxil
Copy link
Collaborator

kaxil commented Mar 11, 2022

Rebase on main for fixing the failing tests

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #114 (c25232a) into main (e4c4b34) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #114   +/-   ##
=======================================
  Coverage   95.33%   95.33%           
=======================================
  Files          35       35           
  Lines        1952     1952           
=======================================
  Hits         1861     1861           
  Misses         91       91           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4c4b34...c25232a. Read the comment docs.

@sunank200 sunank200 marked this pull request as ready for review March 11, 2022 09:04
@kaxil kaxil closed this Mar 14, 2022
@kaxil kaxil reopened this Mar 14, 2022
# extensions coming with Sphinx (named 'sphinx.ext.*') or your custom
# ones.
extensions = [
"autoapi.extension",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://readthedocs.org/projects/astronomer-providers/builds/16358761/ is failing.

You should add this dependency to setup.cfg and include it in a new extra: doc and install it for readthedocs.yml

docs/conf.py Outdated Show resolved Hide resolved
@kaxil kaxil force-pushed the add-docs branch 2 times, most recently from c3e68c3 to 4a08427 Compare March 15, 2022 00:34
@kaxil kaxil merged commit 271e56d into main Mar 15, 2022
@kaxil kaxil deleted the add-docs branch March 15, 2022 00:41
@kaxil
Copy link
Collaborator

kaxil commented Mar 15, 2022

I made some changes via the following commits @sunank200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Sphinx to autogenerate user-facing docs
2 participants