Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Delay to GCS sensor #118

Merged
merged 5 commits into from
Mar 14, 2022
Merged

Add Delay to GCS sensor #118

merged 5 commits into from
Mar 14, 2022

Conversation

bharanidharan14
Copy link
Contributor

@bharanidharan14 bharanidharan14 commented Mar 11, 2022

  • Added Delay task for GCS Sensor to show the sensors is deferred and changed the upstream of the Task
  • Changed the bucket name

Issue id: #116

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #118 (0d073ac) into main (226dccd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   95.33%   95.33%           
=======================================
  Files          35       35           
  Lines        1952     1952           
=======================================
  Hits         1861     1861           
  Misses         91       91           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 226dccd...0d073ac. Read the comment docs.

@kaxil
Copy link
Collaborator

kaxil commented Mar 11, 2022

Can you update your PR description - currently it says "Bug fix" -- Bug fix for what?

The PR description should say what you are fixing or what is the issue

@bharanidharan14 bharanidharan14 changed the title Bug fix Bug fix: Add Delay to GCS sensor Mar 11, 2022
@bharanidharan14 bharanidharan14 changed the title Bug fix: Add Delay to GCS sensor Add Delay to GCS sensor Mar 11, 2022
Copy link
Collaborator

@phanikumv phanikumv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bharanidharan14 please get the PR description updated. We can then merge it.

Copy link
Collaborator

@phanikumv phanikumv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mention issue link in PR description please

@phanikumv phanikumv merged commit 4e2d467 into main Mar 14, 2022
@phanikumv phanikumv deleted the bug_fix branch March 14, 2022 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants