Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docstrings for BigQueryTableExistenceSensorAsync #150

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Conversation

kaxil
Copy link
Collaborator

@kaxil kaxil commented Mar 23, 2022

This PR/commit fixes docstrings so they are rendered correctly in Sphinx.

Before:

image

After:

image

This PR/commit fixes docstrings so they are rendered correctly in Sphinx.
Service Account Token Creator IAM role to the directly preceding identity, with first
account from the list granting this role to the originating account (templated).
:param polling_interval: The interval in seconds to wait between checks table existence.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't found a good way to automate this check, where we have a blank link after summary and parameters, pydocstyle does have some but not this, so if any of you have any ideas please feel free to create an issue and take it over :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #150 (4d0967f) into main (2c86d13) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files          36       36           
  Lines        2017     2017           
=======================================
  Hits         1928     1928           
  Misses         89       89           
Impacted Files Coverage Δ
...ronomer/providers/google/cloud/sensors/bigquery.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c86d13...4d0967f. Read the comment docs.

Copy link
Collaborator

@sunank200 sunank200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Service Account Token Creator IAM role to the directly preceding identity, with first
account from the list granting this role to the originating account (templated).
:param polling_interval: The interval in seconds to wait between checks table existence.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

@kaxil kaxil merged commit 368a677 into main Mar 23, 2022
@kaxil kaxil deleted the fix-docstrings branch March 23, 2022 15:22
Copy link
Collaborator

@phanikumv phanikumv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants