-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docstrings for BigQueryTableExistenceSensorAsync
#150
Conversation
This PR/commit fixes docstrings so they are rendered correctly in Sphinx.
Service Account Token Creator IAM role to the directly preceding identity, with first | ||
account from the list granting this role to the originating account (templated). | ||
:param polling_interval: The interval in seconds to wait between checks table existence. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't found a good way to automate this check, where we have a blank link after summary and parameters, pydocstyle
does have some but not this, so if any of you have any ideas please feel free to create an issue and take it over :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay
Codecov Report
@@ Coverage Diff @@
## main #150 +/- ##
=======================================
Coverage 95.58% 95.58%
=======================================
Files 36 36
Lines 2017 2017
=======================================
Hits 1928 1928
Misses 89 89
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Service Account Token Creator IAM role to the directly preceding identity, with first | ||
account from the list granting this role to the originating account (templated). | ||
:param polling_interval: The interval in seconds to wait between checks table existence. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good !
This PR/commit fixes docstrings so they are rendered correctly in Sphinx.
Before:
After: