Enable MyPy in strict mode

[kaxil]

Enable MyPy in a strict mode and run via docker instead of pre-commit so the stubs are installed.

closes #65

[sunank200]

Added mypy fixes for all amazon operators, sensors along with HTTPSensorAsync.

[kaxil]

Adding Any everywhere doesn't help! It is same as not adding type hints at all

[kaxil]

The idea of adding type hints is so we know what type a variable/arguments/param is. Adding Any doesn't give any info

[sunank200]

In BaseSensorOperator, it uses Any. That was the reason for using Any. link

[kaxil]

Any is only used for the return type of execute in that link. Dict[Any, Any] is the same as dict

[pankajastro]

I can see a couple of inconsistencies on which we need to conclude

def execute(self, context: "Context") -> Any:
def execute(self, context: Dict[Any, Any]) -> None:
def execute(self, context: Context) -> None:
def execute(self, context: Context) -> Any:  # type: ignore[override]
def execute(self, context: Dict[str, Any]) -> None:

def execute_complete(self, context: Dict[Any, Any], event: Optional[Dict[Any, Any]] = None) -> None:
def execute_complete(self, context: Context, event: Any) -> Any:
def execute_complete(self, context: 'Context', event: Any = None) -> None:

async def run(self) -> None:
async def run(self) -> AsyncIterator["TriggerEvent"]:  # type: ignore[override]

[kaxil]

I can see a couple of inconsistencies on which we need to conclude

I agree. For now, let's park it and we can discuss this next week

[codecov]

Codecov Report

Merging #60 (3441429) into main (d20a90b) will decrease coverage by 0.15%.
The diff coverage is 93.29%.

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   89.92%   89.76%   -0.16%     
==========================================
  Files          35       35              
  Lines        1796     1818      +22     
==========================================
+ Hits         1615     1632      +17     
- Misses        181      186       +5     

Impacted Files	Coverage Δ
...ronomer/providers/snowflake/operators/snowflake.py	60.60% <62.50%> (+0.60%)	⬆️
...roviders/cncf/kubernetes/hooks/kubernetes_async.py	59.45% <66.66%> (ø)
astronomer/providers/http/hooks/http.py	88.73% <66.66%> (-1.27%)	⬇️
...mer/providers/amazon/aws/operators/redshift_sql.py	89.28% <75.00%> (-3.03%)	⬇️
...r/providers/amazon/aws/sensors/redshift_cluster.py	84.00% <80.00%> (-2.96%)	⬇️
astronomer/providers/snowflake/hooks/snowflake.py	79.68% <80.00%> (ø)
astronomer/providers/core/sensors/external_task.py	93.54% <85.71%> (-2.75%)	⬇️
...nomer/providers/databricks/operators/databricks.py	80.00% <85.71%> (-1.25%)	⬇️
astronomer/providers/google/cloud/sensors/gcs.py	95.83% <90.90%> (-2.00%)	⬇️
astronomer/providers/amazon/aws/hooks/s3.py	93.93% <100.00%> (ø)
... and 18 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d20a90b...3441429. Read the comment docs.

[kaxil]

🎉 Ok, I have finally got this in !! We also have it running in the CI