Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CodeCoverage toleration #95

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Conversation

kaxil
Copy link
Collaborator

@kaxil kaxil commented Mar 4, 2022

This PR adds some toleration for Code Coverage.

It won't always be the case that we can achieve the coverage we need. 2% is an arbitrary number currently, we can increase or decrease in future.

This PR adds some toleration for Code Coverage.

It won't always be the case that we can achieve the coverage we need. 2% is  an arbitrary number currently, we can increase or decrease in future.
@kaxil kaxil requested review from sunank200 and phanikumv March 4, 2022 12:35
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #95 (41b73cc) into main (b13f44d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   88.09%   88.09%           
=======================================
  Files          35       35           
  Lines        1529     1529           
=======================================
  Hits         1347     1347           
  Misses        182      182           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b13f44d...41b73cc. Read the comment docs.

Copy link
Collaborator

@sunank200 sunank200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@phanikumv phanikumv merged commit e3c53bb into main Mar 4, 2022
@phanikumv phanikumv deleted the allow-toleration-coverage branch March 4, 2022 13:58
phanikumv pushed a commit that referenced this pull request Mar 5, 2022
This PR adds some toleration for Code Coverage.

It won't always be the case that we can achieve the coverage we need. 2% is  an arbitrary number currently, we can increase or decrease in future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants