Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user and users data source #102

Merged
merged 23 commits into from
Jul 8, 2024
Merged

Add user and users data source #102

merged 23 commits into from
Jul 8, 2024

Conversation

ichung08
Copy link
Collaborator

@ichung08 ichung08 commented Jul 2, 2024

Description

Add user and users data source to terraform provider astro.

🎟 Issue(s)

#101

🧪 Functional Testing

  • added new acceptance tests
  • can get a user and output its value:
Screenshot 2024-07-03 at 1 15 33 AM
  • can list users
Screenshot 2024-07-03 at 8 48 54 AM

📸 Screenshots

📋 Checklist

  • Added/updated applicable tests
  • Added/updated examples in the examples/ directory
  • Updated any related documentation

@ichung08 ichung08 self-assigned this Jul 2, 2024
@ichung08 ichung08 linked an issue Jul 2, 2024 that may be closed by this pull request
@ichung08 ichung08 marked this pull request as ready for review July 3, 2024 17:10
@ichung08 ichung08 requested review from vandyliu, sunkickr and a team as code owners July 3, 2024 17:10
@@ -80,22 +80,21 @@ import {
to = astro_deployment.imported_deployment
}
resource "astro_deployment" "imported_deployment" {
original_astro_runtime_version = "11.3.0"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this as it was causing issues with importing deployments. when running terraform plan it stated that a new resource was to be created and another to be deleted. after removing this field, when running tf import it stated a resource was to be updated instead (which is the intended behaviour).

@ichung08 ichung08 enabled auto-merge (squash) July 8, 2024 16:42
@ichung08 ichung08 merged commit ce2636c into main Jul 8, 2024
7 checks passed
@ichung08 ichung08 deleted the 101-add-users-data-source branch July 8, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add users data source
2 participants