Add Team Resource #118
Add Team Resource #118
Conversation
internal/provider/models/team.go
Outdated
| if orgRole != "" && orgRole != string(iam.ORGANIZATIONMEMBER) { | ||
| data.OrganizationRole = types.StringValue(orgRole) | ||
| } else { | ||
| data.OrganizationRole = types.StringNull() | ||
| } |
There was a problem hiding this comment.
wrote it this way because i kept hitting Provider produced inconsistent result after apply and because the API sets org role to org member automatically if org role is not provided
|
@vandyliu do we want to support update team roles in create and update? |
internal/provider/schemas/team.go
Outdated
| Computed: true, | ||
| MarkdownDescription: "The roles assigned to the workspaces", | ||
| }, | ||
| "deployment_roles": resourceSchema.SetNestedAttribute{ | ||
| NestedObject: resourceSchema.NestedAttributeObject{ | ||
| Attributes: ResourceDeploymentRoleSchemaAttributes(), | ||
| }, | ||
| Computed: true, |
There was a problem hiding this comment.
should prob be optional or maybe even required but can be empty
There was a problem hiding this comment.
changed to optional - should not be required as teams don't have to have deployment_roles
internal/provider/schemas/team.go
Outdated
| MarkdownDescription: "The IDs of the users to add to the Team", | ||
| Optional: true, | ||
| Validators: []validator.Set{ | ||
| setvalidator.SizeAtLeast(1), |
There was a problem hiding this comment.
does it have to be 1, can we have empty team?
There was a problem hiding this comment.
yes we can have empty team - will change
| @@ -0,0 +1,70 @@ | |||
| package common | |||
There was a problem hiding this comment.
added this file for shared role functions
needed to create a new directory because if i had it in utils i would hit an import cycle error since models, resources and utils reference each other in a cycle
| @@ -47,11 +47,14 @@ func TestAccPreCheck(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func ProviderConfig(t *testing.T, isHosted bool) string { | |||
| func ProviderConfig(t *testing.T, isHosted bool, isScim bool) string { | |||
There was a problem hiding this comment.
added this param to the signature and had to update all the files accordingly (which is why all the test files were affected)
| }, | ||
| }, | ||
| }), | ||
| ExpectError: regexp.MustCompile("Invalid Configuration: Cannot create, update or delete a Team resource when SCIM is enabled"), |
Description
Add support for team resource on terraform.
Supports:
🎟 Issue(s)
#112
🧪 Functional Testing
Create
Update
Delete
📸 Screenshots
📋 Checklist
examples/directory