Add User Invite Resource #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichung08
commented
Aug 2, 2024
Comment on lines
-87
to
-98
| fullName := fmt.Sprintf("users.%d.full_name", usersIdx) | ||
| if instanceState.Attributes[fullName] == "" { | ||
| return fmt.Errorf("expected 'full_name' to be set") | ||
| } | ||
| status := fmt.Sprintf("users.%d.status", usersIdx) | ||
| if instanceState.Attributes[status] == "" { | ||
| return fmt.Errorf("expected 'status' to be set") | ||
| } | ||
| avatarUrl := fmt.Sprintf("users.%d.avatar_url", usersIdx) | ||
| if instanceState.Attributes[avatarUrl] == "" { | ||
| return fmt.Errorf("expected 'avatar_url' to be set") | ||
| } |
There was a problem hiding this comment.
when we create new user invites, those users can be found in our org but by default they do not have the fields fullName or avatarUrl populated
removed so the test would not check those fields (as they'll always be empty for user invites)
vandyliu
reviewed
Aug 2, 2024
vandyliu
reviewed
Aug 2, 2024
| ) { | ||
| var data models.UserInvite | ||
|
|
||
| // Delete existing user invite |
There was a problem hiding this comment.
comment seems outta place
There was a problem hiding this comment.
maybe we can add this to above the function definition of what we're gonna do something like
1. Delete existing user invite
2. Create a new user invite
<reason why>
There was a problem hiding this comment.
added the comment to make it clear that we delete the existing user invite first and then create a new user invite (since we don't have an update user invite endpoint)
vandyliu
reviewed
Aug 2, 2024
vandyliu
reviewed
Aug 2, 2024
vandyliu
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for user invite resource on terraform.
🎟 Issue(s)
#113
🧪 Functional Testing
Create user invite
Update user invite
Delete user invite
📸 Screenshots
📋 Checklist
examples/directory