Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guard for invalid deploymentId in team creation #144

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

ichung08
Copy link
Collaborator

@ichung08 ichung08 commented Aug 28, 2024

Description

Adds a guard checking for invalid deployment ids in team deployment roles during creation. deletes the team if any errors are found.

🎟 Issue(s)

Based off of error here: https://github.com/astronomer/astro/issues/23585

🧪 Functional Testing

📸 Screenshots

📋 Checklist

  • Added/updated applicable tests
  • Added/updated examples in the examples/ directory
  • Updated any related documentation

@ichung08 ichung08 self-assigned this Aug 28, 2024
@ichung08 ichung08 marked this pull request as ready for review August 28, 2024 20:07
@ichung08 ichung08 requested review from vandyliu, sunkickr and a team as code owners August 28, 2024 20:07
@ichung08 ichung08 merged commit 180adf9 into main Aug 28, 2024
9 checks passed
@ichung08 ichung08 deleted the 133-add-guard-for-invalid-deployment-ids-in-team branch August 28, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants