fix validator #43
Merged
fix validator #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredzhy
reviewed
Apr 25, 2024
| @@ -131,7 +131,7 @@ func HibernationOverrideResourceSchemaAttributes() map[string]resourceSchema.Att | |||
| "is_hibernating": resourceSchema.BoolAttribute{ | |||
| Optional: true, | |||
| Validators: []validator.Bool{ | |||
| boolvalidator.AlsoRequires(path.MatchRoot("override_until")), | |||
| boolvalidator.AlsoRequires(path.MatchRelative().AtParent().AtName("override_until")), | |||
There was a problem hiding this comment.
do you mind explaining what these functions do and why it was broken before, sorry missing some context here
There was a problem hiding this comment.
at the parent of this param match an element by the provided name "override_until". Require that param if this param is provided.
There was a problem hiding this comment.
MatchRoot doesn't start at the parent but instead at the root of the object so "override_until" could not be found.
fredzhy
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in the validator used by the override spec
🎟 Issue(s)
🧪 Functional Testing
📸 Screenshots
📋 Checklist
examples/directory