Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cluster db instance computed #90

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Make cluster db instance computed #90

merged 3 commits into from
Jun 13, 2024

Conversation

vandyliu
Copy link
Collaborator

@vandyliu vandyliu commented Jun 12, 2024 •
edited
Loading

Description

  • makes dbInstanceType computed

🎟 Issue(s)

#85

🧪 Functional Testing

added tests

📸 Screenshots

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Added/updated applicable tests
  • Added/updated examples in the examples/ directory
  • Tested against Astro-API
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@vandyliu vandyliu marked this pull request as ready for review June 12, 2024 21:21
@vandyliu vandyliu requested review from sunkickr and a team as code owners June 12, 2024 21:21
@vandyliu vandyliu merged commit 9df178c into main Jun 13, 2024
7 checks passed
@vandyliu vandyliu deleted the make-cluster-db-instance-computed branch June 13, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frank-ye frank-ye frank-ye approved these changes

@sunkickr sunkickr Awaiting requested review from sunkickr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vandyliu @frank-ye