Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when setting null scaling spec on update #94

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Fix bug when setting null scaling spec on update #94

merged 3 commits into from
Jun 26, 2024

Conversation

vandyliu
Copy link
Collaborator

@vandyliu vandyliu commented Jun 25, 2024 •
edited
Loading

Description

  • when updating a deployment that has a scaling spec to one that doesnt, there were terraform provider errors
  • this PR fixes them by setting an empty ScalingSpecRequest. Previously, a null ScalingSpecRequest sent to the API server meant to not update the scaling spec but what we actually want is to remove the scaling spec.

🎟 Issue(s)

n/a

🧪 Functional Testing

  • added to acceptance tests
  • tested manually

📸 Screenshots

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Added/updated applicable tests
  • Added/updated examples in the examples/ directory
  • Tested against Astro-API
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@vandyliu vandyliu marked this pull request as ready for review June 25, 2024 23:47
@vandyliu vandyliu requested review from sunkickr and a team as code owners June 25, 2024 23:47
@vandyliu vandyliu merged commit ef45e59 into main Jun 26, 2024
7 checks passed
@vandyliu vandyliu deleted the fix-null-scaling-spec branch June 26, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frank-ye frank-ye frank-ye approved these changes

@sunkickr sunkickr Awaiting requested review from sunkickr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vandyliu @frank-ye