Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make numpy required dependency #113

Merged
merged 2 commits into from
Aug 8, 2023
Merged

make numpy required dependency #113

merged 2 commits into from
Aug 8, 2023

Conversation

maxwest-uw
Copy link
Contributor

Change Description

makes numpy a required dependency and sets the version to be < 1.25.

closes #111

  • My PR includes a link to the issue that I am addressing

Solution Description

we use numpy < 1.25 because numba (new hipscat dependency) hasn't been updated to support 1.25 yet.

seems like numpy==1.25 suport will be added to numba==0.58, which is due sometime in the next couple of months. ticket here.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@maxwest-uw maxwest-uw marked this pull request as draft August 1, 2023 22:09
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #113 (7c27b4d) into main (01f2120) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #113   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          729       729           
=========================================
  Hits           729       729           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maxwest-uw
Copy link
Contributor Author

this pr will also close #115 as I figured out that some bad configuration was causing test_margin_cache_gen was making the test run really slow :bowtie:

@maxwest-uw maxwest-uw marked this pull request as ready for review August 8, 2023 17:42
@maxwest-uw maxwest-uw merged commit eb9ce72 into main Aug 8, 2023
13 checks passed
@maxwest-uw maxwest-uw deleted the issues/111 branch October 25, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make numpy a required dependency
2 participants