Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
makes
numpy
a required dependency and sets the version to be < 1.25.closes #111
Solution Description
we use
numpy < 1.25
becausenumba
(newhipscat
dependency) hasn't been updated to support 1.25 yet.seems like
numpy==1.25
suport will be added tonumba==0.58
, which is due sometime in the next couple of months. ticket here.Code Quality